+Arx/src/core/SaveGame.cpp:112:14: style: Local variable 'save' shadows outer function [shadowFunction] +Arx/src/core/SaveGame.cpp:205:19: style: Local variable 'save' shadows outer function [shadowFunction] -Arx/src/gui/Menu.h:61:1: style: The struct 'ARX_MENU_DATA' does not have a constructor although it has private member variables. [noConstructor] +Arx/src/gui/Menu.h:61:1: style: The struct 'ARX_MENU_DATA' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] +Arx/src/gui/widget/TextInputWidget.cpp:98:17: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] +Arx/src/gui/widget/TextInputWidget.cpp:148:17: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] +Arx/src/gui/widget/Widget.cpp:46:5: style: Condition 'm_enabled' is always true [knownConditionTrueFalse] -Arx/src/gui/widget/WidgetContainer.cpp:41:39: style: Parameter 'selected' can be declared with const [constParameter] +Arx/src/gui/widget/WidgetContainer.cpp:41:39: style: Parameter 'selected' can be declared as pointer to const [constParameter] +Arx/src/io/Blast.cpp:93:8: error: Using argument s that points at uninitialized variable s [ctuuninitvar] +Arx/src/io/Blast.cpp:314:15: style: Variable 'litcnt' is not assigned a value. [unassignedVariable] +Arx/src/io/Blast.cpp:314:36: style: Variable 'litsym' is not assigned a value. [unassignedVariable] +Arx/src/io/Blast.cpp:315:15: style: Variable 'lencnt' is not assigned a value. [unassignedVariable] +Arx/src/io/Blast.cpp:315:36: style: Variable 'lensym' is not assigned a value. [unassignedVariable] +Arx/src/io/Blast.cpp:316:15: style: Variable 'distcnt' is not assigned a value. [unassignedVariable] +Arx/src/io/Blast.cpp:316:37: style: Variable 'distsym' is not assigned a value. [unassignedVariable] +Arx/src/io/IniReader.cpp:111:10: error: Returning pointer that will be invalid when returning. [returnDanglingLifetime] +Arx/src/io/IniReader.cpp:157:11: style: Local variable 'end' shadows outer function [shadowFunction] +Arx/src/io/SaveBlock.cpp:60:46: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] +Arx/src/io/SaveBlock.cpp:62:50: style: Operator '|' with one operand equal to zero is redundant. [badBitmaskCheck] +Arx/src/io/fs/FilePath.cpp:240:13: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] -Arx/src/io/fs/FilesystemBoost.cpp:106:26: style: Redundant condition: If 'type == 0', the comparison 'type != 1' is always true. [redundantCondition] +Arx/src/io/fs/FilesystemBoost.cpp:106:26: style: Redundant condition: The condition 'type == 0' is redundant since 'type != 1' is sufficient. [redundantCondition] +Arx/src/io/resource/PakReader.cpp:89:14: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:91:18: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:107:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:109:6: style: The function 'seek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:111:9: style: The function 'tell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:148:20: style: Condition 'm_offset>m_file.m_size' is always false [knownConditionTrueFalse] +Arx/src/io/resource/PakReader.cpp:197:14: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:199:18: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:215:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:217:6: style: The function 'seek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:219:9: style: The function 'tell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:389:14: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:391:18: style: The function 'open' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:406:9: style: The function 'read' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:408:6: style: The function 'seek' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/PakReader.cpp:410:9: style: The function 'tell' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] +Arx/src/io/resource/ResourcePath.cpp:240:13: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr] -Arx/src/platform/Endian.h:229:14: style: Unused private function: 'little_endian::reversed' [unusedPrivateFunction] -Arx/src/platform/Endian.h:232:11: style: Unused private function: 'little_endian::decode' [unusedPrivateFunction] -Arx/src/platform/Endian.h:241:14: style: Unused private function: 'little_endian::encode' [unusedPrivateFunction] -Arx/src/platform/Endian.h:258:14: style: Unused private function: 'big_endian::reversed' [unusedPrivateFunction] -Arx/src/platform/Endian.h:261:11: style: Unused private function: 'big_endian::decode' [unusedPrivateFunction] -Arx/src/platform/Endian.h:270:14: style: Unused private function: 'big_endian::encode' [unusedPrivateFunction] -Arx/src/platform/Environment.cpp:560:27: error: Uninitialized variable: path [uninitvar] +Arx/src/platform/Environment.cpp:560:27: error: Uninitialized variable: path [legacyUninitvar] +Arx/src/platform/WindowsUtils.cpp:36:7: style: Local variable 'length' shadows outer function [shadowFunction] +Arx/src/platform/WindowsUtils.cpp:43:6: style: Local variable 'length' shadows outer function [shadowFunction] +Arx/src/platform/crashhandler/CrashHandlerPOSIX.cpp:122:17: style: struct member 'PlatformCrashHandlers::illHandler' is never used. [unusedStructMember] +Arx/src/platform/crashhandler/CrashHandlerPOSIX.cpp:124:17: style: struct member 'PlatformCrashHandlers::busHandler' is never used. [unusedStructMember] +Arx/src/platform/crashhandler/CrashHandlerWindows.cpp:192:50: style: C-style pointer casting [cstyleCast] +Arx/src/platform/crashhandler/CrashProcessorPOSIX.cpp:307:14: style: struct member 'MemoryRegion::file' is never used. [unusedStructMember] +Arx/src/scene/Background.cpp:103:25: style: Variable 'eg2' can be declared as reference to const [constVariable] -Arx/src/scene/LinkedObject.cpp:65:78: style: Parameter 'tounlink' can be declared with const [constParameter] +Arx/src/scene/LinkedObject.cpp:65:78: style: Parameter 'tounlink' can be declared as pointer to const [constParameter] -Arx/src/util/IteratedHash.h:119:1: style: The class 'iterated_hash < md5_transform >' does not have a constructor although it has private member variables. [noConstructor] -Arx/src/util/IteratedHash.h:119:1: style: The class 'iterated_hash' does not have a constructor although it has private member variables. [noConstructor] +Arx/src/util/IteratedHash.h:119:1: style: The class 'iterated_hash < md5_transform >' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] +Arx/src/util/IteratedHash.h:119:1: style: The class 'iterated_hash' does not declare a constructor although it has private member variables which likely require initialization. [noConstructor] +Arx/src/util/cmdline/Parser.cpp:86:15: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use resize() or pop_back() instead. [uselessCallsSubstr] +Arx/src/window/SDL2X11Util.c:39:8: style: struct member 'SysWMinfo::padding' is never used. [unusedStructMember] -Arx/tools/crashreporter/qhexedit/QHexEdit.h:63:1: style: The class 'QHexEdit' does not have a constructor although it has private member variables. [noConstructor] +Arx/tools/crashreporter/qhexedit/QHexEdit.h:71:2: error: There is an unknown macro here somewhere. Configuration is required. If Q_PROPERTY is a macro then please configure it. [unknownMacro] -Arx/tools/crashreporter/tbg/HTTPClientWindows.cpp:136:63: style: Parameter 'redirect' can be declared with const [constParameter] +Arx/tools/crashreporter/tbg/HTTPClientWindows.cpp:136:63: style: Parameter 'redirect' can be declared as reference to const [constParameter] -Arx/tools/crashreporter/ui/ErrorReportDialog.h:62:7: style: The function 'taskStarted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] -Arx/tools/crashreporter/ui/ErrorReportDialog.h:63:7: style: The function 'taskStepStarted' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] -Arx/tools/crashreporter/ui/ErrorReportDialog.h:64:7: style: The function 'taskStepEnded' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] -Arx/tools/crashreporter/ui/ErrorReportDialog.h:68:7: style: The function 'setError' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] -Arx/tools/crashreporter/ui/ErrorReportDialog.h:74:7: style: The function 'setDetailedError' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride]